📦️ update typescript-eslint #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still use the ("legacy setup")[1] on purpose: we'll upgrade to a flat
config in a separate PR, when we upgrade ESLint.
[1]: https://typescript-eslint.io/getting-started/legacy-eslint-setup
Rule changes:
* @typescript-eslint/ban-types have been split in multiple rules, most
of them are enabled by default. The configuration we used has been
ported to @typescript-eslint/no-restricted-types
* no-throw-literal isn't needed anymore as the new rule
@typescript-eslint/only-throw-error is covering the same thing and
more.
* @typescript-eslint/no-var-requires was replaced with
@typescript-eslint/no-require-imports.
* @typescript-eslint/no-unused-experessions was turned on in the
recommended rules, but we have a few cases where we avoid using an
`if` like `foo && bar()` that raise that error, so I disabled the rule
for now.
* The new @typescript-eslint/only-throw-error reports quite a few (valid) cases where we don't throw errors. I ignored those as issues as this was generally what we wanted. * Some eslint-disable comments were not needed, so I removed them * Optional properties and arguments that also accept `undefined` now raise an error * typescript-eslint is also better at finding unused variables in catch clauses * And other minor things...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3192 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 280 280
Lines 7703 7705 +2
Branches 1727 1727
=======================================
+ Hits 7200 7202 +2
Misses 503 503 ☔ View full report in Codecov by Sentry. |
cy-moi
approved these changes
Dec 2, 2024
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
| @@ -52,7 +52,7 @@ describe('trackInteractionToNextPaint', () => { | |||
| setViewEnd = interactionToNextPaintTracking.setViewEnd | |||
|
|
|||
| registerCleanupTask(() => { | |||
| interactionToNextPaintTracking.stop | |||
| interactionToNextPaintTracking.stop() | |||
There was a problem hiding this comment.
👏 praise: nice catch!
| @@ -22,7 +22,7 @@ export enum ExperimentalFeature { | |||
|
|
|||
| const enabledExperimentalFeatures: Set<ExperimentalFeature> = new Set() | |||
|
|
|||
| export function initFeatureFlags(enableExperimentalFeatures?: string[] | undefined) { | |||
| export function initFeatureFlags(enableExperimentalFeatures: string[] | undefined) { | |||
Co-authored-by: Thomas Lebeau <thomas.lebeau@datadoghq.com>
thomas-lebeau
approved these changes
Dec 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Keep dependencies up to date. Also, ESLint v8 is not supported anymore, so this is a first toward upgrading ESLint to v9.
Changes
See commit messages.
Testing
I have gone over the contributing documentation.