✨[RUMF-465] collect client service, env and version #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
reviewed
May 15, 2020
bcaudan
suggested changes
May 15, 2020
mquentin
changed the title
bcaudan
changed the title
bcaudan
reviewed
May 18, 2020
bcaudan
reviewed
May 18, 2020
bcaudan
approved these changes
May 18, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allows users to configure optional fields that tag their RUM events and logs with a specific service, environment and version.
Changes
New optional configuration options have been added to the log, rum init process. If define, these new fields will then create new tags for each of the logs and RUM events send to the intake.
Testing
clientService, clientEnv, clientVersionfields to thewindow.DD_RUM.init and window.DD_LOGS.init&ddtags=sdk_version:dev,env:envaaa,service:serviceaaa,version:versionaaa