🐛[RUMF-559] prevent event without sessionId #425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some events are sent to the intake without a session id.
Scenario to reproduce:
then the second tab still considers to be on the last view of the first session, so
viewContext.sessionId = undefined
.Events can be added to the batch because
session.isTracked() = true
due to the value of the cookie.No matter what is the visibility state of the second tab, we don't want to create a new view and collect the associated events before any real user action on this tab.
Changes
Ensure that
viewContext.sessionId
is defined to allow events to be added to the batch.I have gone over the contributing documentation.