✨[RUMF-594] specify same site attribute on cookies #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Firefox has started to display a warning for all used cookies that don't specify a same site attribute.
Let's specify one to get rid of it.
fixes #430
Changes
Specify
samesite=stricton all our cookies updates, we don't need to pass cookies to server requests, so let's use the more restrictive option.cf https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie#Write_a_new_cookie
Testing
Tested in dev, warning has disappeared in firefox.
I have gone over the contributing documentation.