-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUMF-617] Extract XHR and Fetch proxies #468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the design to ease the testing not mandatory but I lost some time suspecting an issue with that...
bcaudan
force-pushed
the
bcaudan/extract-singleton-for-proxy
branch
2 times, most recently
from
July 29, 2020 13:42
c454de2
to
59061d3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 87.41% 87.50% +0.08%
==========================================
Files 32 34 +2
Lines 2034 2112 +78
Branches 411 416 +5
==========================================
+ Hits 1778 1848 +70
- Misses 256 264 +8 ☔ View full report in Codecov by Sentry. |
bcaudan
force-pushed
the
bcaudan/extract-singleton-for-proxy
branch
from
July 29, 2020 13:44
59061d3
to
76017bd
Compare
bcaudan
changed the title
[RUMF-617] Extract XHR and Fetch proxy
[RUMF-617] Extract XHR and Fetch proxies
Jul 29, 2020
bcaudan
force-pushed
the
bcaudan/extract-singleton-for-proxy
branch
from
July 29, 2020 13:47
76017bd
to
c311c29
Compare
prevent batch from previous tests to keep running and send unwanted requests
BenoitZugmeyer
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current proxies of XHR and fetch were managed by request collection which was handled as a singleton to avoid to proxy XHR and fetch multiple times.
With the future integration of tracing inside the sdk (cf #461), we would want to collect request with trace id for rum but not for logs.
In a npm setup this would be problematic since the request collection instance would be shared between rum and logs.
Changes
Testing
Automated tests
I have gone over the contributing documentation.