Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[RUMF-639] xhr proxy: do not instrument xhr already opened #484

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Aug 13, 2020

Motivation

Issue raised by customer

Changes

Check that xhr has been instrumented on open to instrument send

Testing

Automated tests


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner August 13, 2020 08:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #484 into master will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   87.73%   87.60%   -0.14%     
==========================================
  Files          34       34              
  Lines        2112     2113       +1     
  Branches      413      414       +1     
==========================================
- Hits         1853     1851       -2     
- Misses        259      262       +3     
Impacted Files Coverage Δ
packages/core/src/xhrProxy.ts 100.00% <100.00%> (ø)
packages/rum/src/parentContexts.ts 98.21% <0.00%> (-1.79%) ⬇️
packages/rum/src/rum.ts 89.23% <0.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f911e...c4777d4. Read the comment docs.

@bcaudan bcaudan merged commit c4b6a50 into master Aug 13, 2020
@bcaudan bcaudan deleted the bcaudan/fix-xhr-proxy branch August 13, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants