-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUMF-621] set view referrer to the previous view URL #507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with Small NIT
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 87.61% 87.94% +0.33%
==========================================
Files 35 35
Lines 2156 2157 +1
Branches 434 434
==========================================
+ Hits 1889 1897 +8
+ Misses 267 260 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Motivation
For
route_change
views, use the previous view URL as referrer.Changes
For the sake of simplicity, lifecycle types have been improved a bit so we can re-use them easily. Then, the referrer has been set to the View context so it can be used everywher the View context is used. Finally, the view collections is retrieving the previous view URL when creating the new view on URL change or session renew.
Testing
I have gone over the contributing documentation.