Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ SDK: Add new functionality to remove global context to SDK #527

Merged
merged 3 commits into from
Sep 10, 2020

Conversation

buenjybar
Copy link
Contributor

Motivation

Allow users to remove a global context.

Changes

  • Implements removeGlobalContext in the Log package

  • Implements removeGlobalContext to the Rum package

Testing

add some unittests


I have gone over the contributing documentation.

 * Implements removeGlobalContext in the Log package

 * Implements removeGlobalContext to the Rum package
@buenjybar buenjybar requested a review from a team as a code owner September 10, 2020 12:04
@bits-bot
Copy link

bits-bot commented Sep 10, 2020

CLA assistant check
All committers have signed the CLA.

@bcaudan
Copy link
Contributor

bcaudan commented Sep 10, 2020

Hi @buenjybar,

Thanks for this PR!
Would you mind signing the CLA?

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #527 into master will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
+ Coverage   88.05%   88.09%   +0.04%     
==========================================
  Files          36       36              
  Lines        2269     2277       +8     
  Branches      467      467              
==========================================
+ Hits         1998     2006       +8     
  Misses        271      271              
Impacted Files Coverage Δ
packages/logs/src/logs.entry.ts 49.25% <0.00%> (-1.52%) ⬇️
packages/rum/src/rum.entry.ts 74.62% <0.00%> (-2.30%) ⬇️
packages/logs/src/logger.ts 95.40% <100.00%> (+1.28%) ⬆️
packages/rum/src/rum.ts 92.70% <100.00%> (+2.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa3b4c...386bd59. Read the comment docs.

Copy link
Contributor Author

@buenjybar buenjybar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting all the linter issues,
somehow I was not able to run it with npm 💯

@bcaudan bcaudan merged commit b832cc6 into DataDog:master Sep 10, 2020
@BenoitZugmeyer
Copy link
Member

Hi @buenjybar, your PR has been released in v1.20.0. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants