Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[RUMF-650] exclude intake request from performance/request collection #528

Merged
merged 3 commits into from
Sep 11, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Sep 10, 2020

Motivation

avoid page activities to consider intake requests

Changes

  • move check on url before life cycle event generation
  • keep session check before resource event generation

Testing

Automated test


I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #528 into master will decrease coverage by 0.03%.
The diff coverage is 91.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
- Coverage   88.18%   88.15%   -0.04%     
==========================================
  Files          36       36              
  Lines        2277     2287      +10     
  Branches      467      473       +6     
==========================================
+ Hits         2008     2016       +8     
- Misses        269      271       +2     
Impacted Files Coverage Δ
packages/rum/src/tracer.ts 100.00% <ø> (ø)
packages/rum/src/requestCollection.ts 90.24% <84.61%> (+1.67%) ⬆️
packages/rum/src/performanceCollection.ts 68.57% <92.30%> (+3.41%) ⬆️
packages/core/src/errorCollection.ts 98.80% <100.00%> (ø)
packages/core/src/fetchProxy.ts 97.72% <100.00%> (ø)
packages/core/src/xhrProxy.ts 100.00% <100.00%> (ø)
packages/rum/src/resourceUtils.ts 97.26% <100.00%> (ø)
packages/rum/src/rum.entry.ts 74.62% <100.00%> (ø)
packages/rum/src/rum.ts 91.97% <100.00%> (-0.73%) ⬇️
packages/logs/src/loggerSession.ts 95.65% <0.00%> (-4.35%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b832cc6...8c773dc. Read the comment docs.

@bcaudan bcaudan marked this pull request as ready for review September 10, 2020 13:06
@bcaudan bcaudan requested a review from a team as a code owner September 10, 2020 13:06
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! I like the idea of filtering URLs at a lower level :) Some small typings suggestions but other than that LGTM

packages/rum/src/requestCollection.ts Outdated Show resolved Hide resolved
packages/rum/src/requestCollection.ts Outdated Show resolved Hide resolved
packages/rum/src/requestCollection.ts Outdated Show resolved Hide resolved
packages/rum/src/requestCollection.ts Outdated Show resolved Hide resolved
@bcaudan bcaudan merged commit b4f0fa2 into master Sep 11, 2020
@bcaudan bcaudan deleted the bcaudan/early-request-filter branch September 11, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants