Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUMF-620]: Dual-ship "service" as tag and attribute #543

Merged
merged 1 commit into from
Sep 23, 2020
Merged

[RUMF-620]: Dual-ship "service" as tag and attribute #543

merged 1 commit into from
Sep 23, 2020

Conversation

glorieux
Copy link
Contributor

@glorieux glorieux commented Sep 23, 2020 •
edited
Loading

Motivation

The move of service from tag to attribute must be done in two steps to ease the transition.

Changes

Send service as attribute as well as tag.

Testing

I have gone over the contributing documentation.

Closes #501

@glorieux glorieux requested a review from a team as a code owner September 23, 2020 06:49
@glorieux glorieux merged commit 77ea092 into master Sep 23, 2020
@glorieux glorieux deleted the glorieux/service-dual-shipping branch September 23, 2020 08:56
@xepps xepps mentioned this pull request Oct 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcaudan bcaudan bcaudan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glorieux @bcaudan