Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 consider proxy host with custom path request as intake request #550

Merged
merged 1 commit into from
Oct 5, 2020
Merged

🐛 consider proxy host with custom path request as intake request #550

merged 1 commit into from
Oct 5, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Oct 2, 2020 •
edited
Loading

Motivation

Some customers hi-jack the host to also have a path.
Since it is working, ensure that it is fully supported.

Changes

  • check that request contain v1/input, not only start with it
  • doc: replace proxy url by proxy host with an example to avoid confusion

Testing

automated tests

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner October 2, 2020 13:09
@bcaudan bcaudan requested a review from a team October 2, 2020 13:12
@bcaudan bcaudan mentioned this pull request Oct 2, 2020
Merged
3 tasks
apigirl
apigirl approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the docs

@bcaudan bcaudan merged commit b8185c5 into master Oct 5, 2020
@bcaudan bcaudan deleted the bcaudan/host-intake-request branch October 5, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

@apigirl apigirl apigirl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcaudan @BenoitZugmeyer @apigirl