🐛[RUMF-716] fix invalid action name #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some UTF-8 characters can be composed of a pair of "surrogate" characters. Ensure that our string truncate don't make invalid string by keeping only the first part of the pair. more details https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent
There was a problem hiding this comment.
Good catch!
I think that testing if the character at the ending position is part of a surrogate pair would be nicer.
Something like:
// tslint:disable-next-line: no-bitwise
if ((candidate.charCodeAt(length - 1) & 0xf800) === 0xd800) {
return candidate.slice(0, length + 1)
}
return candidate.slice(0, length)WDYT?
BenoitZugmeyer
approved these changes
Oct 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
+ Coverage 89.31% 89.69% +0.37%
==========================================
Files 38 38
Lines 2265 2270 +5
Branches 473 474 +1
==========================================
+ Hits 2023 2036 +13
+ Misses 242 234 -8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some UTF-8 characters can be composed of a pair of "surrogate" characters.
more details: MDN#encodeURIComponent
Changes
Ensure that our string truncate don't make invalid string by keeping only the first part of the pair.
Testing
unit test
I have gone over the contributing documentation.