-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] dereference combine
sources recursively
#560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
changed the title
Benoit/deep clone
[Core] dereference Oct 12, 2020
combine
arguments recursively
BenoitZugmeyer
changed the title
[Core] dereference
[Core] dereference Oct 12, 2020
combine
arguments recursivelycombine
sources recursively
bcaudan
reviewed
Oct 13, 2020
* rename a few tests * test references with `.not.toBe`
bcaudan
reviewed
Oct 13, 2020
bcaudan
approved these changes
Oct 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 88.23% 88.52% +0.29%
==========================================
Files 39 39
Lines 2260 2275 +15
Branches 472 476 +4
==========================================
+ Hits 1994 2014 +20
+ Misses 266 261 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up of #551 (comment)
We figured that our
combine
implementation was not de-referencing all sub values. This could lead to unexpected behavior when some context is stored in an event to be pushed in the future (like: pre-init addUserAction or log) and a context sub-value is mutated in the meantime.Changes
deepMerge
(andcombine
) implementation to always dereference their argumentsdeepClone
function to explicitly dereference a value.Testing
Some unit tests have been added
I have gone over the contributing documentation.