✨ [RUMF-534] implement logs.onReady and rum.onReady #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
reviewed
Oct 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
==========================================
- Coverage 88.26% 88.08% -0.19%
==========================================
Files 39 39
Lines 2275 2282 +7
Branches 476 477 +1
==========================================
+ Hits 2008 2010 +2
- Misses 267 272 +5
Continue to review full report at Codecov.
|
BenoitZugmeyer
force-pushed
the
benoit/define-on-ready
branch
from
f0c6890
to
7d99925
Compare
BenoitZugmeyer
commented
Oct 14, 2020
test/e2e/lib/framework/pageSetups.ts
Outdated
| @@ -31,16 +31,20 @@ export const DEFAULT_SETUPS = [ | |||
| export function asyncSetup(options: SetupOptions) { | |||
| let body = options.body || '' | |||
|
|
|||
| function formatSnippet(url: string, globalName: string) { | |||
| return `(function(r,a,w,l,s) { | |||
There was a problem hiding this comment.
"rawls" is a The Wire reference
There was a problem hiding this comment.
nice one but I don't think that the wire references are publicly shared 🙂
what about something dog related instead? hound would fit 😉
bcaudan
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Have a proper way to execute code when the SDK is ready.
Changes
logs.onReadyandrum.onReadyto execute previously stored callbacksTesting
I have gone over the contributing documentation.