🐛 [RUMF-742] fix cookie creation domain when trackSessionAcrossSubdomains: true #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as `getCurrentSite`, the `areCookiesAuthorized` could return incorrect results if a SDK is initialized multiple times with different options, or on multiple domains. This is a lot less likely to happen though.
bcaudan
reviewed
Oct 19, 2020
bcaudan
approved these changes
Oct 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
==========================================
+ Coverage 88.12% 88.13% +0.01%
==========================================
Files 46 46
Lines 2357 2359 +2
Branches 491 492 +1
==========================================
+ Hits 2077 2079 +2
Misses 280 280
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The function
getCurrentSitecan yield invalid result when a SDK is initialized multiple times within 1 second.Changes
getCurrentSiteresultgetCurrentSiteTesting
Setup the RUM SDK on a test page, and print its internal context. Beforehand, clear any cookie on the current domain. Then, refresh the page quickly 2 times: the session should stay the same, and the cookie should be created with a valid domain.
I have gone over the contributing documentation.