Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-745] fix V2 context #579

Merged
merged 2 commits into from
Oct 21, 2020
Merged

🐛 [RUMF-745] fix V2 context #579

merged 2 commits into from
Oct 21, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Oct 20, 2020

Motivation

in v2, customer attributes are encapsulated in a context attribute

Changes

move customer attribute to context

Testing

unit tests


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner October 20, 2020 16:11
packages/rum/src/domain/assemblyV2.spec.ts Outdated Show resolved Hide resolved
packages/rum/src/domain/assemblyV2.ts Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #579 into master will decrease coverage by 0.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
- Coverage   88.68%   88.13%   -0.56%     
==========================================
  Files          46       46              
  Lines        2359     2359              
  Branches      492      492              
==========================================
- Hits         2092     2079      -13     
- Misses        267      280      +13     
Impacted Files Coverage Δ
packages/rum/src/domain/assemblyV2.ts 100.00% <100.00%> (ø)
packages/rum/src/domain/parentContexts.ts 85.29% <0.00%> (-11.77%) ⬇️
packages/rum/src/transport/batch.ts 73.17% <0.00%> (-9.76%) ⬇️
packages/rum/src/browser/performanceCollection.ts 67.14% <0.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 701a0f8...ded2533. Read the comment docs.

@bcaudan bcaudan merged commit aa56f5e into master Oct 21, 2020
@bcaudan bcaudan deleted the bcaudan/fix-context branch October 21, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants