✨[RUMF-738] migrate view to v2 format (experimental) #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
changed the title
Codecov Report
@@ Coverage Diff @@
## bcaudan/resources #586 +/- ##
=====================================================
+ Coverage 87.95% 88.58% +0.63%
=====================================================
Files 47 48 +1
Lines 2382 2391 +9
Branches 493 495 +2
=====================================================
+ Hits 2095 2118 +23
+ Misses 287 273 -14
Continue to review full report at Codecov.
|
bcaudan
commented
Oct 22, 2020
packages/rum/src/boot/rum.spec.ts
Outdated
| @@ -10,7 +10,7 @@ import { | |||
| SESSION_KEEP_ALIVE_INTERVAL, | |||
| THROTTLE_VIEW_UPDATE_PERIOD, | |||
| View, | |||
| } from '../domain/rumEventsCollection/view/viewCollection' | |||
| } from '../domain/rumEventsCollection/view/trackViews' | |||
There was a problem hiding this comment.
This naming is not really satisfying since trackXxx and xxxCollection means pretty much the same thing 😕
I'd be willing to go with that for now and wait the end of the migration to have a better overview and see what we can do.
bcaudan
commented
Oct 22, 2020
| @@ -114,6 +83,34 @@ describe('rum session', () => { | |||
| expect(subsequentRequests[0].view.id).not.toEqual(initialRequests[0].view.id) | |||
| }) | |||
|
|
|||
| it('when the session is renewed, a new view event should be sent', () => { | |||
There was a problem hiding this comment.
Some of the remaining tests are integration tests, it could be interesting to see what we want to do with them at some point.
BenoitZugmeyer
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following #570, migrating view to v2 format
Changes
Testing
unit tests, staging
I have gone over the contributing documentation.