Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUMF-766] prevent request duration override by wrong matching timing #604

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Nov 4, 2020

Motivation

Quick fix to see if demo website shorter browser spans could be related to wrong timing association.
Since TAO is not enabled on shopist, we should observe a duration increase for RUM fetch events.

Changes

Do not consider invalid or incomplete timing in match request timing.

Testing

unit test, manual tests on DD + demo

Next steps

if hypothesis is confirmed, discuss proper strategies.


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner November 4, 2020 15:25
Reduce risk of matching error by not considering invalid or incomplete timing due to cross origin restrictions.
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #604 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   88.83%   88.85%   +0.01%     
==========================================
  Files          54       54              
  Lines        2490     2503      +13     
  Branches      540      541       +1     
==========================================
+ Hits         2212     2224      +12     
- Misses        278      279       +1     
Impacted Files Coverage Δ
...rumEventsCollection/resource/matchRequestTiming.ts 94.11% <100.00%> (ø)
...main/rumEventsCollection/resource/resourceUtils.ts 96.42% <100.00%> (+0.42%) ⬆️
packages/rum/test/fixtures.ts 100.00% <100.00%> (ø)
packages/rum/src/browser/performanceCollection.ts 64.28% <0.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b84be22...bbdb14f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants