New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [RUMF-764] Use new intake domain for US #616

Merged

webNeat merged 23 commits into master from amine/use-public-intake

Dec 3, 2020

Contributor

webNeat commented Nov 13, 2020

Motivation

Use the new public intake for US site

Changes

Applies the new intake domain when the US site is used in the configuration.

Testing

Unit tests of configuration generation have been updated.

I have gone over the contributing documentation.

webNeat requested a review from a team as a code owner

November 13, 2020 12:56

webNeat force-pushed the amine/use-public-intake branch from decec59 to 2227121 Compare

November 13, 2020 12:58

codecov-io commented Nov 13, 2020 •

edited

Loading

Codecov Report

Merging #616 (e3fe145) into master (f8c339b) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
- Coverage   87.78%   87.57%   -0.21%     
==========================================
  Files          56       56              
  Lines        2578     2591      +13     
  Branches      556      551       -5     
==========================================
+ Hits         2263     2269       +6     
- Misses        315      322       +7

Impacted Files	Coverage Δ
...ckages/core/src/domain/automaticErrorCollection.ts	`98.41% <100.00%> (-1.59%)`	⬇️
packages/core/src/domain/configuration.ts	`90.41% <100.00%> (+3.74%)`	⬆️
...main/rumEventsCollection/resource/resourceUtils.ts	`96.42% <100.00%> (ø)`
packages/rum/src/transport/batch.ts	`63.63% <0.00%> (-11.37%)`	⬇️
packages/core/src/tools/urlPolyfill.ts	`60.97% <0.00%> (-4.88%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c339b...e3fe145. Read the comment docs.

bcaudan suggested changes

View reviewed changes

Contributor

bcaudan left a comment •

edited

Loading

it is not the correct endpoint for logs
we should also use the new domain in staging
we should probably handle new and old endpoints for isIntakeRequest if there is another sdk running with the old endpoints.

webNeat force-pushed the amine/use-public-intake branch from 2227121 to fa30e8c Compare

November 16, 2020 18:17

webNeat requested a review from bcaudan

November 16, 2020 18:21

webNeat force-pushed the amine/use-public-intake branch 2 times, most recently from 4ea711f to 83e5924 Compare

November 17, 2020 14:35

bcaudan reviewed

View reviewed changes

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

packages/core/src/boot/init.ts Outdated Show resolved Hide resolved

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

webNeat force-pushed the amine/use-public-intake branch 3 times, most recently from 7b66768 to 454a50e Compare

November 20, 2020 14:01

bcaudan reviewed

View reviewed changes

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

webNeat force-pushed the amine/use-public-intake branch from 454a50e to 6c85bd3 Compare

November 20, 2020 17:35

BenoitZugmeyer reviewed

View reviewed changes

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

webNeat added 9 commits

November 23, 2020 17:19


          🏷️ [RUM] Use enum for endpoint type

569e0aa


          ✨ [RUM] Use new intake domain for US

723bd92


          🎨 [RUM] Refactor isIntakeRequest()

7f89562


          ✨ [RUM] Support legacy endpoints

3a75832


          🎨 [RUM] Use indexOf() instead of includes() to support IE 11

cc99182


          🎨 [RUM] Precompute intake urls

73f4c35


          🎨 [RUM] Use .some() instead of for..of

7ccedc6


          🎨 [RUM] Remove unused imports

87228b9


          🎨 [RUM] Replace isIntakeRequest by configuration.isIntakeUrl

9d75102

webNeat force-pushed the amine/use-public-intake branch from 2f237bd to 9d75102 Compare

November 23, 2020 16:19

bcaudan approved these changes

View reviewed changes

Contributor

bcaudan left a comment

Nice job


          ✨ [RUM] Add configuration option to use new intake domains

d187810

bcaudan reviewed

View reviewed changes

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

bcaudan reviewed

View reviewed changes

packages/core/src/domain/configuration.spec.ts Outdated Show resolved Hide resolved

bcaudan reviewed

View reviewed changes

packages/core/src/domain/configuration.spec.ts Outdated Show resolved Hide resolved

bcaudan reviewed

View reviewed changes

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

webNeat and others added 5 commits

November 26, 2020 12:08


          🎨 [RUM] Remove uneeded lines

ea48e31


          🎨 [RUM] Use either new or old intake domains

16d83b8


          🎨 [RUM] Rename configuration option to useAlternateIntakeDomains

5bee248


          Merge branch 'master' into amine/use-public-intake

c843fb3


          ✅ [RUM] Fix unit tests

927d7df

bcaudan reviewed

View reviewed changes

packages/core/src/domain/configuration.spec.ts Outdated Show resolved Hide resolved

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

packages/core/src/boot/init.ts Outdated Show resolved Hide resolved

webNeat added 3 commits

November 30, 2020 15:29


          👌 Remove list of allowed sites in favor of specifying them in docs

4fc29bc


          🏷️ Refactor types to account for alternate intake

7fd2e40


          🎨 Refactor code to eliminate duplication

fd3c833

webNeat force-pushed the amine/use-public-intake branch from d291473 to fd3c833 Compare

December 1, 2020 11:42

bcaudan reviewed

View reviewed changes

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

webNeat added 2 commits

December 1, 2020 15:55


          👌 Remove uneeded property

0758cb1


          👌 Handle sites with subdomains

48a0ffc

bcaudan reviewed

View reviewed changes

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved


          👌 Support classic intake for sites with subdomains

4ba25a4

webNeat force-pushed the amine/use-public-intake branch from 2bd74ed to 4ba25a4 Compare

December 2, 2020 11:24

bcaudan reviewed

View reviewed changes

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved

packages/core/src/domain/configuration.ts Outdated Show resolved Hide resolved


          👌 Simplify the code

e3fe145

bcaudan approved these changes

View reviewed changes

Contributor

bcaudan left a comment

Nice!


          Merge branch 'master' into amine/use-public-intake

812b230

webNeat merged commit 515bc4b into master

webNeat deleted the amine/use-public-intake branch

December 3, 2020 11:41

This was referenced Jul 12, 2021

[Snyk] Upgrade @datadog/browser-core from 1.12.9 to 1.26.3 hixio-mh/browser-sdk#15

Open

[Snyk] Upgrade @datadog/browser-core from 1.12.9 to 1.26.3 hixio-mh/browser-sdk#16

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet