✨ [RUMF-780] implement track first hidden #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
changed the title
bcaudan
reviewed
Nov 16, 2020
bcaudan
reviewed
Nov 16, 2020
packages/rum/src/domain/rumEventsCollection/view/trackTimings.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Nov 17, 2020
bcaudan
reviewed
Nov 17, 2020
According to review: * restore prod behavior for passive events listeners * support custom emitter, allowing to add listeners on `document` (for `visibilitychange` event) and any mocked object or element (for unit test) * add documentation * rename the function since it's not 'global' anymore
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
==========================================
- Coverage 88.89% 88.23% -0.66%
==========================================
Files 54 56 +2
Lines 2503 2525 +22
Branches 541 546 +5
==========================================
+ Hits 2225 2228 +3
- Misses 278 297 +19
Continue to review full report at Codecov.
|
bcaudan
reviewed
Nov 18, 2020
packages/rum/src/domain/rumEventsCollection/view/trackFirstHidden.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/rumEventsCollection/view/trackFirstHidden.spec.ts
Show resolved
Hide resolved
packages/rum/src/domain/rumEventsCollection/view/trackFirstHidden.spec.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Nov 18, 2020
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we are tracking particular performance entries only if the page is not hidden when initializing the SDK (see #361 ). The issue with this strategy is: if the page is visible when initializing RUM, but it gets hidden before the
first-contentful-paintis produced, the metric will be incorrect.We want to replace this strategy with something similar to
web-vitals. It'll provide stronger guarantees that the page was not hidden prior to the observed performance entry.Changes
trackFirstHiddentrackFirstHiddenwhen collecting FCPTesting
I have gone over the contributing documentation.