Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-758] keep internal context in v1 format (experimental) #625

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Nov 19, 2020

Motivation

Following #593, keep compatibility with logs data format

Changes

in v2, internal context still returns v1 format

Testing

unit, staging


I have gone over the contributing documentation.

keep compatibility with logs data format
@bcaudan bcaudan requested a review from a team as a code owner November 19, 2020 10:13
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice :) We'll update the POC so it uses a fixed browser-sdk version (via NPM). Could you wait a bit before merging this PR to master (and deploy to staging)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants