Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 [RUMF-730] use v2 events format #627

Merged
merged 11 commits into from
Dec 14, 2020
Merged

💥 [RUMF-730] use v2 events format #627

merged 11 commits into from
Dec 14, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Nov 23, 2020

Motivation

Use the same event format as the one used to display the data.

Changes

Breaking:
Remove RUM event types export

Other:

  • Remove v1 specific code + v2 references
  • Remove v2_format feature flag
  • fix loadEvent naming

Testing

automated tests


I have gone over the contributing documentation.

@bcaudan bcaudan force-pushed the bcaudan/v2 branch 2 times, most recently from 0d6f55c to 762f223 Compare November 23, 2020 12:55
@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #627 (283ca04) into master (f8c339b) will decrease coverage by 0.41%.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   87.78%   87.36%   -0.42%     
==========================================
  Files          56       54       -2     
  Lines        2578     2454     -124     
  Branches      556      515      -41     
==========================================
- Hits         2263     2144     -119     
+ Misses        315      310       -5     
Impacted Files Coverage Δ
packages/rum/src/boot/rum.entry.ts 92.06% <ø> (ø)
packages/rum/src/boot/rum.ts 50.00% <0.00%> (-2.00%) ⬇️
packages/rum/src/domain/lifeCycle.ts 100.00% <ø> (ø)
...rc/domain/rumEventsCollection/view/trackTimings.ts 100.00% <ø> (ø)
packages/rum/src/domain/trackEventCounts.ts 100.00% <ø> (ø)
packages/rum/src/transport/batch.ts 77.77% <0.00%> (+2.77%) ⬆️
packages/rum/src/domain/assembly.ts 100.00% <100.00%> (ø)
packages/rum/src/domain/internalContext.ts 100.00% <100.00%> (ø)
packages/rum/src/domain/parentContexts.ts 98.24% <100.00%> (+2.65%) ⬆️
...ain/rumEventsCollection/action/actionCollection.ts 94.11% <100.00%> (-2.32%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c339b...283ca04. Read the comment docs.

@bcaudan bcaudan changed the title Bcaudan/v2 💥 [RUMF-730] use v2 events format Nov 23, 2020
@bcaudan bcaudan marked this pull request as ready for review November 23, 2020 14:58
@bcaudan bcaudan requested a review from a team as a code owner November 23, 2020 14:58
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bcaudan bcaudan merged commit 761ad54 into master Dec 14, 2020
@bcaudan bcaudan deleted the bcaudan/v2 branch May 5, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants