✨ [RUMF-777] implement Cumulative Layout Shift #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
reviewed
Nov 23, 2020
Comment on lines
138
to
141
| const { stop: stopCLSTracking } = trackLayoutShift(lifeCycle, (layoutShift) => { | ||
| cumulativeLayoutShift = (cumulativeLayoutShift || 0) + layoutShift | ||
| scheduleViewUpdate() | ||
| }) |
There was a problem hiding this comment.
Suggested change
| const { stop: stopCLSTracking } = trackLayoutShift(lifeCycle, (layoutShift) => { | |
| cumulativeLayoutShift = (cumulativeLayoutShift || 0) + layoutShift | |
| scheduleViewUpdate() | |
| }) | |
| if (isLayoutShiftSupported()) { | |
| cumulativeLayoutShift = 0 | |
| const { stop: stopCLSTracking } = trackLayoutShift(lifeCycle, (layoutShift) => { | |
| cumulativeLayoutShift = cumulativeLayoutShift + layoutShift | |
| scheduleViewUpdate() | |
| }) | |
| } |
then we would avoid to handle undefined case in callback.
It could probably remove the need to check the support in the track function.
There was a problem hiding this comment.
We still need to handle the undefined case (for typings), but it's a bit easier to follow, so I just used a ! operator. 👍
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Expose the web-vitals CLS on all views
Changes
Testing
CI + manual tests
I have gone over the contributing documentation.