Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-791] prevent IE11 performance entry error #633

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Nov 24, 2020

Motivation

toJSON is not available in IE11, prevent execution error

Changes

check if toJSON available before using it

Testing

manual


I have gone over the contributing documentation.

toJSON is not available in IE11, prevent execution error
@bcaudan bcaudan requested a review from a team as a code owner November 24, 2020 10:14
Co-authored-by: Benoît Zugmeyer <benoit.zugmeyer@datadoghq.com>
@codecov-io
Copy link

Codecov Report

Merging #633 (092dbb7) into master (a5c6271) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
+ Coverage   87.76%   87.78%   +0.01%     
==========================================
  Files          56       56              
  Lines        2575     2578       +3     
  Branches      555      556       +1     
==========================================
+ Hits         2260     2263       +3     
  Misses        315      315              
Impacted Files Coverage Δ
...rumEventsCollection/resource/matchRequestTiming.ts 95.00% <100.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c6271...092dbb7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants