-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUMF-770] Disable tracing for cancelled requests #635
Conversation
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
==========================================
+ Coverage 87.78% 87.93% +0.15%
==========================================
Files 56 56
Lines 2578 2577 -1
Branches 556 555 -1
==========================================
+ Hits 2263 2266 +3
+ Misses 315 311 -4
Continue to review full report at Codecov.
|
Co-authored-by: Bastien Caudan <bastien.caudan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This is expected. This PR disables traces for those requests, but they are still considered as errors. Could you provide more information about your issue/use-case? |
Ok, |
Motivation
Do not trace cancelled requests because they lack backend information.
Changes
Set
request.traceId
toundefined
if the request was cancelled.Testing
Added unit tests to ensure that
traceId
is removed from theLifeCycleEventType.REQUEST_COMPLETED
event when therequest.status == 0
.I have gone over the contributing documentation.