✨ [RUMF-794] Add isActive attribute to view events #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webNeat
force-pushed
the
amine.benhammou/view-is-active
branch
from
fc4014d
to
35580e3
Compare
bcaudan
reviewed
Dec 15, 2020
packages/rum/src/domain/rumEventsCollection/view/trackViews.spec.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Dec 15, 2020
packages/rum/src/domain/rumEventsCollection/view/trackViews.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/rumEventsCollection/view/trackViews.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/rumEventsCollection/view/trackViews.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bastien Caudan <bastien.caudan@datadoghq.com>
| ;({ handler, getViewEvent } = spyOnViews()) | ||
|
|
||
| setupBuilder = setup() | ||
| .withFakeClock() |
There was a problem hiding this comment.
NIT: the fake clock is not used here, it could be removed
BenoitZugmeyer
approved these changes
Dec 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
=======================================
Coverage 87.75% 87.75%
=======================================
Files 55 55
Lines 2531 2531
Branches 524 524
=======================================
Hits 2221 2221
Misses 310 310
Continue to review full report at Codecov.
|
bcaudan
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds a new attribute
isActiveto view events, indicating if the view is currently active or not.Changes
Testing
I have gone over the contributing documentation.