Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monit execution failed false negative on dd-agent processes #204

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

NouemanKHAL
Copy link
Member

@NouemanKHAL NouemanKHAL commented Sep 19, 2023

What does this PR do?

Fix an error where monit reports the job as "Execution Failed" even though the process is healthy. This is a known bug in monit, See more Deployment fails because monit reports job as failed and race condition when using check program.

Description of the Change

Increase the startup timeout for all the dd-agent processes, by default monit will wait 30s, this PR increases that value to 90s.

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@NouemanKHAL NouemanKHAL added the changelog/Fixed Fixed features results into a bug fix version bump label Sep 19, 2023
@NouemanKHAL NouemanKHAL requested a review from a team as a code owner September 19, 2023 07:44
@NouemanKHAL NouemanKHAL merged commit 456271a into master Sep 19, 2023
@NouemanKHAL NouemanKHAL deleted the noueman/fix-process-agent-failure branch September 19, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants