Allow the docker build CI jobs to be retried #10774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L3n41c
added
team/containers
changelog/no-changelog
[deprecated] qa/skip-qa - use other qa/ labels
vboulineau
reviewed
Feb 4, 2022
.gitlab/image_build/docker_linux.yml
Outdated
| @@ -20,6 +20,8 @@ | |||
| - docker build --build-arg CIBUILD=true $BUILD_ARG --file $BUILD_CONTEXT/$ARCH/Dockerfile --pull --tag ${TARGET_TAG}-unsquashed $BUILD_CONTEXT | |||
| - docker-squash ${TARGET_TAG}-unsquashed -t ${TARGET_TAG} | |||
| - docker push $TARGET_TAG | |||
| # Workaround for temporary network failures | |||
| retry: 1 | |||
There was a problem hiding this comment.
IMHO we can push that to 2 or 3
L3n41c
force-pushed
the
lenaic/ci_retry
branch
from
fda5498 to
c0165e3
Compare
mx-psi
reviewed
Feb 4, 2022
davidor
approved these changes
Feb 4, 2022
mx-psi
reviewed
Feb 4, 2022
.gitlab/image_build/docker_linux.yml
Outdated
| @@ -20,6 +20,8 @@ | |||
| - docker build --build-arg CIBUILD=true $BUILD_ARG --file $BUILD_CONTEXT/$ARCH/Dockerfile --pull --tag ${TARGET_TAG}-unsquashed $BUILD_CONTEXT | |||
| - docker-squash ${TARGET_TAG}-unsquashed -t ${TARGET_TAG} | |||
| - docker push $TARGET_TAG | |||
| # Workaround for temporary network failures | |||
| retry: 3 | |||
There was a problem hiding this comment.
Maximum seems to be 2 https://docs.gitlab.com/ee/ci/yaml/#retry
to workaround temporary network failures.
L3n41c
force-pushed
the
lenaic/ci_retry
branch
from
c0165e3 to
f1288b0
Compare
mx-psi
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow the docker build CI jobs to be retried to workaround temporary network failures.
Motivation
We regularly receive notifications of GitLab job failures, including on the
mainbranch and, when we look at them, it’s quite common that it’s because of temporary network failures like:or
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.team/..label has been applied, if known.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.need-change/operatorandneed-change/helmlabels have been applied.