Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/otlp: Add instrumentation_scope_metadata_as_tags #12393

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Jun 14, 2022

What does this PR do?

Add a new flag named instrumentation_scope_metadata_as_tags to deprecate the current flag, instrumentation_library_metadata_as_tags.

Motivation

Since https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v0.15.0, InstrumentationLibrary had been deprecated and open-telemetry/opentelemetry-collector#5219 removed it eventually.

This is confusing since the rest of the project has moved to the new name, so we should introduce a new flag that uses the instrumentation scope name, and deprecate the current one.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@keisku keisku marked this pull request as ready for review June 14, 2022 03:45
@keisku keisku requested review from a team as code owners June 14, 2022 03:45
@keisku keisku added this to the 7.38.0 milestone Jun 14, 2022
@keisku keisku marked this pull request as draft June 14, 2022 03:47
@keisku keisku marked this pull request as ready for review June 14, 2022 04:55
@keisku keisku requested a review from mx-psi June 14, 2022 14:08
pkg/otlp/model/translator/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sgnn7 sgnn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for agent-core owned files (config template)

Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a tiny edit, approving so as not to block on it

pkg/otlp/internal/serializerexporter/config.go Outdated Show resolved Hide resolved
@keisku keisku merged commit 7b7b9d5 into main Jun 14, 2022
@keisku keisku deleted the keisku/AP-1707 branch June 14, 2022 22:55
usamasaqib pushed a commit that referenced this pull request Jul 4, 2022
* add instrumentation_scope_metadata_as_tags, deprecate instrumentation_library_metadata_as_tags

* reno new

* return error if both configs are enabled

* fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants