Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/obfuscate: 35 is a valid CC IIN #15936

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

ajgajg1134
Copy link
Contributor

What does this PR do?

Remove an unnecessary / incorrect check in CC detection. This doesn't change the existing behavior it just cleans the code up (note that in the if above my change that 35 is already included).
And this is correct according to the link in the code, some JCB credit cards have an IIN of 35.

Motivation

I was porting this code to rust for this pr (DataDog/libdatadog#117) And thanks to rust match clause checking it helpfully pointed out that the previous if here already includes 35 as a valid Issuer Identification Number(IIN).

Describe how to test/QA your changes

Already well covered by unit tests :)

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@ajgajg1134 ajgajg1134 added changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Mar 2, 2023
@ajgajg1134 ajgajg1134 added this to the 7.44.0 milestone Mar 2, 2023
@ajgajg1134 ajgajg1134 requested a review from a team as a code owner March 2, 2023 21:08
@ajgajg1134 ajgajg1134 merged commit 2707b7e into main Mar 2, 2023
@ajgajg1134 ajgajg1134 deleted the andrew.glaude/unreachableIF branch March 2, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants