-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[corechecks/ksm] Support HPA v2beta2 again #18580
Conversation
"autoscaling/v2": { | ||
"HorizontalPodAutoscaler": customresources.NewHorizontalPodAutoscalerV2Beta2Factory, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also support v2beta1 ? and v1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could address that separately if needed. This PR only fixes the regression introduced in 7.44.
Just to clarify, metrics for HPA v2beta1 objects are still reported in clusters that support v2beta2.
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: f2630b46-5ad2-470d-a209-859d0a724b77 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just two small capitalization suggestions for "Agent".
releasenotes/notes/ksm-support-hpa-v2beta2-e745b1d2519a7d6c.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
What does this PR do?
Fixes the KSM check to support HPA v2beta2 again.
Support for HPA v2beta2 was broken in agent v7.44 when the kube-state-metrics dependency was upgraded (#15623)
The old kube-state-metrics version that we used only supported HPA v2beta2, so we added some custom code to also support HPA v2. The kube-state-metrics version that we're using now only support v2, so this time we need to add some custom code to support HPA v2beta2.
Fixes #17843
Describe how to test/QA your changes
Deploy the agent with the kubernetes state metrics check enabled. Deploy an HPA. Verify that the
kubernetes_state.hpa.*
metrics are reported both in a recent version of kubernetes (>= 1.23) with HPA v2 and an older version of kubernetes (< 1.23) with HPA v2beta2.Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.