Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] close query chan when finishing the btfhub collector #25500

Merged
merged 1 commit into from
May 10, 2024

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented May 10, 2024

What does this PR do?

fixes #25431

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@paulcacheux paulcacheux force-pushed the paulcacheux/fix-btfhub-sync-v4 branch from 0319777 to 7100f81 Compare May 10, 2024 09:04
@paulcacheux paulcacheux added this to the 7.55.0 milestone May 10, 2024
@paulcacheux paulcacheux marked this pull request as ready for review May 10, 2024 09:08
@paulcacheux paulcacheux requested a review from a team as a code owner May 10, 2024 09:08
@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 10, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@pr-commenter
Copy link

pr-commenter bot commented May 10, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=34018672 --os-family=ubuntu

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 34018672 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@dd-devflow
Copy link

dd-devflow bot commented May 10, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 3e03e40 into main May 10, 2024
222 of 239 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/fix-btfhub-sync-v4 branch May 10, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants