Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USMON-1008: Parse Produce Response #28526

Merged
merged 30 commits into from
Sep 4, 2024

Conversation

DanielLavie
Copy link
Contributor

@DanielLavie DanielLavie commented Aug 18, 2024

What does this PR do?

This PR adds support for parsing Kafka produce responses in the Kernel as part of the USM Kafka monitoring feature in system-probe. It includes capturing error codes and measuring latency for Kafka produce requests.

Motivation

Capturing error codes and latency for Kafka produce requests is crucial, as it provides the same visibility for produce requests that we already offer for fetch requests. This ensures that customers can effectively monitor and analyze their Kafka traffic.

Additional Notes

Possible Drawbacks / Trade-offs

Currently, we only support parsing produce requests with a single partition, so we’ve also limited response parsing to single-partition produce requests. While this hasn't caused issues in our dogfooding environment or with customers so far, we may revisit this decision in the future. Expanding support for multiple partitions would add complexity to the code.

Describe how to test/QA your changes

Load test results:

image

Link to staging deployment

@pr-commenter
Copy link

pr-commenter bot commented Aug 18, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=43523913 --os-family=ubuntu

Note: This applies to commit c533f19

@pr-commenter
Copy link

pr-commenter bot commented Aug 18, 2024

Regression Detector

Regression Detector Results

Run ID: b1775dee-5c6d-4c43-b13c-778a9338d03a Metrics dashboard Target profiles

Baseline: b8d3295
Comparison: 6faf8b6

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
pycheck_lots_of_tags % cpu utilization +2.10 [-0.44, +4.64] Logs
basic_py_check % cpu utilization +2.08 [-0.71, +4.87] Logs
tcp_syslog_to_blackhole ingress throughput +0.51 [-12.16, +13.17] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.33 [-0.55, +1.21] Logs
otel_to_otel_logs ingress throughput +0.06 [-0.75, +0.87] Logs
idle memory utilization +0.06 [+0.01, +0.10] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
file_tree memory utilization -0.55 [-0.64, -0.45] Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 9/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@DanielLavie DanielLavie added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Aug 26, 2024
@DanielLavie DanielLavie changed the title USMON-1008 produce response step by step USMON-1008: Parse Produce Response Aug 26, 2024
@DanielLavie DanielLavie marked this pull request as ready for review August 26, 2024 09:39
@DanielLavie DanielLavie requested a review from a team as a code owner August 26, 2024 09:39
@DanielLavie
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 4, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Sep 4, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 01d4ab5 into main Sep 4, 2024
290 of 296 checks passed
@dd-mergequeue dd-mergequeue bot deleted the daniel.lavie/USMON-1008-produce-response-sbs branch September 4, 2024 16:19
@github-actions github-actions bot added this to the 7.58.0 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants