-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle multiple releases in the create_rc_pr
workflow
#28539
Conversation
[Fast Unit Tests Report] On pipeline 42246386 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Regression DetectorRegression Detector ResultsRun ID: c4954816-865f-4bbb-830d-57d8675bf3de Metrics dashboard Target profiles Baseline: 7f068e9 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.43 | [-0.46, +1.31] | Logs |
➖ | idle | memory utilization | +0.25 | [+0.22, +0.28] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | Logs |
➖ | file_tree | memory utilization | -0.26 | [-0.33, -0.20] | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.37 | [-1.18, +0.44] | Logs |
➖ | basic_py_check | % cpu utilization | -0.56 | [-3.30, +2.18] | Logs |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -1.04 | [-5.83, +3.74] | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -1.38 | [-14.11, +11.35] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
create_rc_pr
workflow
Co-authored-by: pducolin <45568537+pducolin@users.noreply.github.com>
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
…)" This reverts commit 77b9014.
) Reverts #28539. This broke on macOS runners because they use Python 3.12, which has removed distutils. #incident-29883
Co-authored-by: pducolin <45568537+pducolin@users.noreply.github.com> (cherry picked from commit 77b9014)
What does this PR do?
Handle multiple releases in the
create_rc_pr
workflow.The idea is to:
Motivation
The current version of the workflow does not work when we have two releases at the same time, in our current case:
The new version of this workflow will look for all the versions not released yet and trigger a job for each of them
Additional Notes
Workflow example with no new commits on 7.56 and new commits on 7.57: https://github.com/DataDog/datadog-agent/actions/runs/10466407557/job/28983252441?pr=28539
Which created this PR: #28569
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes