Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FA] Test user and group when needed #28634

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Test file user and group only when it's needed

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@coignetp coignetp added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/fleet-automation labels Aug 21, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Aug 21, 2024

[Fast Unit Tests Report]

On pipeline 42675807 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Aug 21, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=42675807 --os-family=ubuntu

Note: This applies to commit 4b081d6

@pr-commenter
Copy link

pr-commenter bot commented Aug 21, 2024

Regression Detector

Regression Detector Results

Run ID: cb7848be-34c5-45b9-8552-4eedc93cf1d1 Metrics dashboard Target profiles

Baseline: 871c079
Comparison: 4b081d6

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
tcp_syslog_to_blackhole ingress throughput +4.39 [-8.84, +17.62] Logs
idle memory utilization +0.68 [+0.64, +0.71] Logs
otel_to_otel_logs ingress throughput +0.63 [-0.18, +1.44] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.29 [-0.52, +1.09] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
basic_py_check % cpu utilization -0.13 [-2.75, +2.49] Logs
pycheck_lots_of_tags % cpu utilization -0.35 [-2.74, +2.04] Logs
file_tree memory utilization -0.56 [-0.63, -0.49] Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@coignetp coignetp marked this pull request as ready for review August 23, 2024 15:12
@coignetp coignetp requested review from a team as code owners August 23, 2024 15:12
@coignetp
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 23, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 8d63bca into main Aug 23, 2024
217 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paul/fa-fix-install-assert branch August 23, 2024 15:33
@github-actions github-actions bot added this to the 7.58.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants