Stop using the deprecated linters.errcheck.ignore in the golangci-lint configuration file

[FlorentClarret]

What does this PR do?

Stop using the deprecated linters.errcheck.ignore in the golangci-lint configuration file

Motivation

• https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/613303294#L822

Additional Notes

• This new option does not support regex, at least yet. @pgimalac opened an issue about it Ignore all functions or functions matching a regex from a package  kisielk/errcheck#250
• It seems there's a bug for functions that are called from the same package. I fixed it in the code using _ = myFunction() since there was only a handful of them located in the same package. I opened an issue for this The -exclude option does not seem to work for functions declared in the same package kisielk/errcheck#251

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: b10fd52a-890e-46ef-9e69-d72150b6b5cc Metrics dashboard Target profiles

Baseline: ec2a4be
Comparison: a36204b

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	basic_py_check	% cpu utilization	+2.82	[+0.11, +5.54]	Logs
➖	otel_to_otel_logs	ingress throughput	+0.23	[-0.58, +1.04]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	Logs
➖	idle	memory utilization	-0.14	[-0.18, -0.11]	Logs
➖	file_tree	memory utilization	-0.37	[-0.43, -0.31]	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.49	[-13.21, +12.23]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.78	[-1.59, +0.02]	Logs
➖	pycheck_lots_of_tags	% cpu utilization	-1.24	[-3.60, +1.12]	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
✅	idle	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=42604128 --os-family=ubuntu

Note: This applies to commit a36204b

[FlorentClarret]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!