Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADXT-483] Add Azure AKS provisioner #28669

Merged
merged 8 commits into from
Aug 23, 2024
Merged

Conversation

KevinFairise2
Copy link
Contributor

What does this PR do?

This PR adds a new provisioner to create a Kubernetes environment using AKS on Azure.

The Provisioner should not be used yet because we have no way to clean resources. The provisioner is working fine with the example added in test/new-e2e/examples. But some more setup is required to have it working on the CI.
It can be addressed in a follow-up PR that would do the general setup for provisioner on datadog-agent

Motivation

Run e2e tests on AKS 🎉

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@KevinFairise2 KevinFairise2 requested review from a team as code owners August 22, 2024 15:31
@pr-commenter
Copy link

pr-commenter bot commented Aug 22, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=42665584 --os-family=ubuntu

Note: This applies to commit 9e17bc3

@pr-commenter
Copy link

pr-commenter bot commented Aug 22, 2024

Regression Detector

Regression Detector Results

Run ID: 5f7dd45b-ff9e-4f01-810f-b325472b85c3 Metrics dashboard Target profiles

Baseline: 70f1f15
Comparison: 9e17bc3

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
otel_to_otel_logs ingress throughput +1.84 [+1.02, +2.65] Logs
pycheck_lots_of_tags % cpu utilization +1.03 [-1.45, +3.51] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.33 [-0.46, +1.12] Logs
idle memory utilization +0.15 [+0.12, +0.18] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
file_tree memory utilization -0.20 [-0.27, -0.14] Logs
tcp_syslog_to_blackhole ingress throughput -0.66 [-13.53, +12.21] Logs
basic_py_check % cpu utilization -1.37 [-4.08, +1.33] Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Contributor

@pducolin pducolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

test/new-e2e/pkg/runner/ci_profile.go Outdated Show resolved Hide resolved
test/new-e2e/pkg/runner/profile.go Outdated Show resolved Hide resolved
test/new-e2e/pkg/runner/profile.go Outdated Show resolved Hide resolved
KevinFairise2 and others added 4 commits August 23, 2024 10:53
Co-authored-by: pducolin <45568537+pducolin@users.noreply.github.com>
Co-authored-by: pducolin <45568537+pducolin@users.noreply.github.com>
Co-authored-by: pducolin <45568537+pducolin@users.noreply.github.com>
@KevinFairise2 KevinFairise2 added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code labels Aug 23, 2024
@KevinFairise2
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 23, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit ee0e612 into main Aug 23, 2024
366 of 367 checks passed
@dd-mergequeue dd-mergequeue bot deleted the kfairise/azure-aks-provisioner branch August 23, 2024 12:59
@github-actions github-actions bot added this to the 7.58.0 milestone Aug 23, 2024
@KevinFairise2 KevinFairise2 changed the title Add a provisioner for AKS [ADXT-483] Add Azure AKS provisioner Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-devx-loops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants