-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apm] ip quantization fix dropped protocol bug #28677
Conversation
Fixes a bug in new IP quantization which was added in #28229
2dbfb4b
to
e038c63
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=42683564 --os-family=ubuntu Note: This applies to commit 36f2b26 |
Regression DetectorRegression Detector ResultsRun ID: e746a7ca-b917-437b-ae19-6e4e336f755b Metrics dashboard Target profiles Baseline: a1ac530 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +1.74 | [-0.95, +4.44] | Logs |
➖ | file_tree | memory utilization | +0.80 | [+0.72, +0.88] | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.10 | [-0.71, +0.91] | Logs |
➖ | idle | memory utilization | +0.02 | [-0.02, +0.06] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.08 | [-2.87, -1.30] | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -2.14 | [-4.60, +0.33] | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -2.74 | [-15.37, +9.89] | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
/merge |
(cherry picked from commit 10b7315)
What does this PR do?
Fixes a bug in the new IP quantization which was added in #28229
Describe how to test/QA your changes
End-to-end QA was performed in #28229
The bug being fixed is tested via the updated unit test.