Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] fix usage of the secl dependency on darwin, and policy loading from outside the agent #28708

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Aug 23, 2024

What does this PR do?

This PR:

  • ensures SIGKILL is defined in SignalConstants on macOS/Darwin, as this is used in some dd-go tests
  • make PopulateFieldsWithRuleActionsData public, as this needs to be used to fix-up the actions in rulesets. Needed for backend validation

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@paulcacheux paulcacheux added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Aug 23, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 23, 2024

Regression Detector

Regression Detector Results

Run ID: 3d26e900-50d2-448d-9800-57089c1e277e Metrics dashboard Target profiles

Baseline: aec7299
Comparison: 5a902b1

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
tcp_syslog_to_blackhole ingress throughput +1.23 [-11.81, +14.27] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.91 [+0.12, +1.70] Logs
basic_py_check % cpu utilization +0.50 [-2.15, +3.14] Logs
file_tree memory utilization +0.20 [+0.13, +0.28] Logs
idle memory utilization +0.02 [-0.01, +0.05] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] Logs
pycheck_lots_of_tags % cpu utilization -0.19 [-2.64, +2.26] Logs
otel_to_otel_logs ingress throughput -0.35 [-1.16, +0.46] Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pr-commenter
Copy link

pr-commenter bot commented Aug 23, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=42697129 --os-family=ubuntu

Note: This applies to commit 5a902b1

@paulcacheux paulcacheux marked this pull request as ready for review August 25, 2024 19:15
@paulcacheux paulcacheux requested a review from a team as a code owner August 25, 2024 19:15
@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 26, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 36bd84e into main Aug 26, 2024
241 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/fix-secl-macos branch August 26, 2024 08:20
@github-actions github-actions bot added this to the 7.58.0 milestone Aug 26, 2024
agent-platform-auto-pr bot pushed a commit that referenced this pull request Aug 26, 2024
…from outside the agent (#28708)

(cherry picked from commit 36bd84e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.57.x changelog/no-changelog component/system-probe qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants