Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump github.com/containerd/containerd to v1.7.20 #28711

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Aug 23, 2024

What does this PR do?

This PR bumps github.com/containerd/containerd to v1.7.20, needed for #28217. It also fixes all the small deprecation warnings.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@paulcacheux paulcacheux changed the title Paulcacheux/bump containerd 1.7.20 bump github.com/containerd/containerd to v1.7.20 Aug 23, 2024
@paulcacheux paulcacheux force-pushed the paulcacheux/bump-containerd-1.7.20 branch from 6ac3dbd to 8cb1e50 Compare August 23, 2024 14:47
@paulcacheux paulcacheux changed the title bump github.com/containerd/containerd to v1.7.20 bump github.com/containerd/containerd to v1.7.20 Aug 23, 2024
@paulcacheux paulcacheux added team/containers changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Aug 23, 2024
@paulcacheux paulcacheux marked this pull request as ready for review August 23, 2024 14:48
@paulcacheux paulcacheux requested review from a team as code owners August 23, 2024 14:48
Copy link

Go Package Import Differences

Baseline: 2d1a104
Comparison: 8cb1e50

binaryosarchchange
agentlinuxamd64
+1, -2
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/protobuf/plugin
+github.com/containerd/platforms
agentlinuxarm64
+1, -2
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/protobuf/plugin
+github.com/containerd/platforms
agentwindowsamd64
+1, -4
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/platforms
-github.com/containerd/containerd/protobuf/plugin
-github.com/containerd/containerd/reference/docker
+github.com/containerd/platforms
dogstatsdlinuxamd64
+1, -4
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/platforms
-github.com/containerd/containerd/protobuf/plugin
-github.com/containerd/containerd/reference/docker
+github.com/containerd/platforms
dogstatsdlinuxarm64
+1, -4
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/platforms
-github.com/containerd/containerd/protobuf/plugin
-github.com/containerd/containerd/reference/docker
+github.com/containerd/platforms
process-agentlinuxamd64
+1, -4
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/platforms
-github.com/containerd/containerd/protobuf/plugin
-github.com/containerd/containerd/reference/docker
+github.com/containerd/platforms
process-agentlinuxarm64
+1, -4
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/platforms
-github.com/containerd/containerd/protobuf/plugin
-github.com/containerd/containerd/reference/docker
+github.com/containerd/platforms
process-agentwindowsamd64
+1, -4
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/platforms
-github.com/containerd/containerd/protobuf/plugin
-github.com/containerd/containerd/reference/docker
+github.com/containerd/platforms
security-agentlinuxamd64
+1, -4
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/platforms
-github.com/containerd/containerd/protobuf/plugin
-github.com/containerd/containerd/reference/docker
+github.com/containerd/platforms
security-agentlinuxarm64
+1, -4
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/platforms
-github.com/containerd/containerd/protobuf/plugin
-github.com/containerd/containerd/reference/docker
+github.com/containerd/platforms
system-probelinuxamd64
+1, -2
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/protobuf/plugin
+github.com/containerd/platforms
system-probelinuxarm64
+1, -2
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/protobuf/plugin
+github.com/containerd/platforms
trace-agentlinuxamd64
+1, -4
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/platforms
-github.com/containerd/containerd/protobuf/plugin
-github.com/containerd/containerd/reference/docker
+github.com/containerd/platforms
trace-agentlinuxarm64
+1, -4
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/platforms
-github.com/containerd/containerd/protobuf/plugin
-github.com/containerd/containerd/reference/docker
+github.com/containerd/platforms
trace-agentwindowsamd64
+1, -4
-github.com/containerd/containerd/errdefs
-github.com/containerd/containerd/platforms
-github.com/containerd/containerd/protobuf/plugin
-github.com/containerd/containerd/reference/docker
+github.com/containerd/platforms

Copy link
Member

@davidor davidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for container-platform files

@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 23, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@pr-commenter
Copy link

pr-commenter bot commented Aug 23, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=42691685 --os-family=ubuntu

Note: This applies to commit 8cb1e50

@dd-devflow
Copy link

dd-devflow bot commented Aug 23, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@pr-commenter
Copy link

pr-commenter bot commented Aug 23, 2024

Regression Detector

Regression Detector Results

Run ID: 7a6c1f99-a808-4523-aa22-65c9e2578102 Metrics dashboard Target profiles

Baseline: 2d1a104
Comparison: 8cb1e50

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
pycheck_lots_of_tags % cpu utilization +2.71 [+0.23, +5.18] Logs
basic_py_check % cpu utilization +1.26 [-1.41, +3.93] Logs
idle memory utilization +0.14 [+0.11, +0.17] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.06 [-0.85, +0.73] Logs
otel_to_otel_logs ingress throughput -0.54 [-1.35, +0.27] Logs
file_tree memory utilization -0.90 [-0.97, -0.84] Logs
tcp_syslog_to_blackhole ingress throughput -3.86 [-16.73, +9.02] Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dd-mergequeue dd-mergequeue bot merged commit 71768e8 into main Aug 23, 2024
234 of 246 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/bump-containerd-1.7.20 branch August 23, 2024 15:46
@github-actions github-actions bot added this to the 7.58.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/agent-security team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants