Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usm: kafka: tests: Verify expected error code exists in the request stats #28714

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

guyarb
Copy link
Contributor

@guyarb guyarb commented Aug 23, 2024

What does this PR do?

Aborts if error code wasn't found in the kafka stats

Motivation

Flaky test

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@guyarb guyarb added changelog/no-changelog team/usm The USM team qa/no-code-change Skip QA week as there is no code change in Agent code labels Aug 23, 2024
@guyarb guyarb requested a review from a team as a code owner August 23, 2024 16:06
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 42703869 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Aug 23, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=42703869 --os-family=ubuntu

Note: This applies to commit 8f0c041

@pr-commenter
Copy link

pr-commenter bot commented Aug 23, 2024

Regression Detector

Regression Detector Results

Run ID: 71d1cf4d-ff0b-4ea6-8aff-a44a8c2b99c2 Metrics dashboard Target profiles

Baseline: 71768e8
Comparison: 8f0c041

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
idle memory utilization +0.13 [+0.10, +0.17] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] Logs
otel_to_otel_logs ingress throughput -0.22 [-1.04, +0.59] Logs
file_tree memory utilization -0.63 [-0.70, -0.56] Logs
basic_py_check % cpu utilization -0.81 [-3.49, +1.87] Logs
pycheck_lots_of_tags % cpu utilization -1.31 [-3.80, +1.18] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -3.07 [-3.86, -2.28] Logs
tcp_syslog_to_blackhole ingress throughput -3.64 [-16.28, +9.00] Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@guyarb
Copy link
Contributor Author

guyarb commented Aug 24, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 24, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 5893bb6 into main Aug 24, 2024
323 checks passed
@dd-mergequeue dd-mergequeue bot deleted the guy.arbitman/fix-kafka-test-panic-2 branch August 24, 2024 14:03
@github-actions github-actions bot added this to the 7.58.0 milestone Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/no-code-change Skip QA week as there is no code change in Agent code team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants