-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[USM] provide pid to file reigstery cleanup #28727
[USM] provide pid to file reigstery cleanup #28727
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=42898612 --os-family=ubuntu Note: This applies to commit 01b1c82 |
Regression DetectorRegression Detector ResultsRun ID: 40e85a1a-68cc-46c1-baf3-ebd3e560849d Metrics dashboard Target profiles Baseline: 30cae01 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +3.19 | [-9.63, +16.02] | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | +1.59 | [-0.95, +4.12] | Logs |
➖ | idle | memory utilization | +0.32 | [+0.27, +0.37] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
➖ | file_tree | memory utilization | -0.52 | [-0.64, -0.41] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.69 | [-1.65, +0.26] | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.86 | [-1.67, -0.05] | Logs |
➖ | basic_py_check | % cpu utilization | -1.93 | [-4.57, +0.70] | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
❌ MergeQueue: The build pipeline contains failing jobs for this merge request Build pipeline has failing jobs for 1e4f948: What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. If you need support, contact us on Slack #devflow with those details! |
11e3c6f
to
85318af
Compare
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
The PR tries as a best effort to guarantee
unregister
callback gets the PID of the program to remove.It should not affect native-library, but only go-tls in a follow up PR.
Motivation
Provide all context available while trying to unregistering a binary.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes