fix: fix slice init length #29744
Merged
fix: fix slice init length #29744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @cuishuang, Nice catch. Thank you so much for the fix 🎉 👏 |
pgimalac
added
changelog/no-changelog
team/agent-shared-components
qa/done
GustavoCaso
approved these changes
Oct 3, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The intention here should be to initialize a slice with a capacity of len(req.State) rather than initializing the length of this slice.
The only demo: https://go.dev/play/p/q1BcVCmvidW
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes