pkg/trace/api: reply using JSON when presampling on v0.4 endpoint #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the response of the presampler to match the version endpoint that is in use. Previously the "OK" response was sent for the `v0.4/traces` endpoint which was inaccurate.
LotharSee
approved these changes
Feb 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #3051 +/- ##
==========================================
+ Coverage 54.15% 54.16% +<.01%
==========================================
Files 540 540
Lines 38262 38262
==========================================
+ Hits 20722 20725 +3
+ Misses 16302 16299 -3
Partials 1238 1238
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the response of the presampler to match the version
endpoint that is in use. Previously the "OK" response was sent for the
v0.4/tracesendpoint which was incorrect and confusing.