[new-e2e] Check empty instance reservations condition for dumpKindClusterState

[fanny-jiang]

What does this PR do?

Fixes a panic/index out of range error in AWS kind provisioner's dumpKindClusterState function that occurs when instancesDescription is not nil but instancesDescription.Reservations = [].

Print statements while debugging:

INSTANCES DESCRIPTION:  &{<nil> [] {map[{}:-718501000 {}:0x140001b47f8 {}:088289ef-7e83-415d-9120-49e8ab06b72e {}:{13967045742491301000 44903162001 0x112b22d60} {}:{0 63871199208 <nil>} {}:{[{<nil> false false {map[{}:-718501000 {}:0x140001b47f8 {}:088289ef-7e83-415d-9120-49e8ab06b72e {}:{13967045742491301000 44903162001 0x112b22d60} {}:{0 63871199208 <nil>}]}}]}]} {}}
INSTANCES DESCRIPTION.RESERVATIONS:  []
=== NAME  TestAWSKindSuite
    panic.go:115: test panicked: runtime error: index out of range [0] with length 0

Motivation

bugfix

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 52349568 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 2c0aedb5c5a457aafcd802d953979746b63c05db

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	1011.42MB	1011.42MB	140.00MB
datadog-agent-x86_64-rpm	0.00MB	✅	1020.73MB	1020.73MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	✅	1020.73MB	1020.73MB	140.00MB
datadog-agent-arm64-deb	0.00MB	✅	940.77MB	940.77MB	140.00MB
datadog-agent-aarch64-rpm	0.00MB	✅	950.07MB	950.07MB	140.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	58.62MB	58.62MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	58.70MB	58.70MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	58.70MB	58.70MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.13MB	56.13MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	506.15MB	506.15MB	70.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.80MB	113.80MB	10.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.87MB	113.87MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.87MB	113.87MB	10.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	109.25MB	109.25MB	10.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	109.32MB	109.32MB	10.00MB

Decision

✅ Passed

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52349568 --os-family=ubuntu

Note: This applies to commit 6e36305

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 347a5924-166f-44b3-a9a9-f88e3dac7230

Baseline: 2c0aedb
Comparison: 6e36305
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_tree	memory utilization	+0.27	[+0.13, +0.40]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.24	[+0.15, +0.33]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.19	[-0.58, +0.95]	1	Logs
➖	quality_gate_idle	memory utilization	+0.13	[+0.09, +0.17]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.09	[-0.79, +0.98]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.08	[-0.76, +0.93]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.13, +0.11]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.80, +0.78]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.02	[-0.94, +0.90]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.02	[-0.66, +0.62]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.05	[-0.74, +0.63]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.13	[-0.60, +0.33]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.58	[-1.25, +0.10]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.68	[-1.75, -1.60]	1	Logs
➖	quality_gate_logs	% cpu utilization	-2.33	[-5.52, +0.85]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

[fanny-jiang]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2025-01-07 16:19:53 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2025-01-07 17:30:02 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 36m.

---

2025-01-07 18:10:58 UTC ℹ️ MergeQueue: This merge request was merged