Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pyyaml patch #3520

Merged
merged 14 commits into from
May 22, 2019
Merged

Use pyyaml patch #3520

merged 14 commits into from
May 22, 2019

Conversation

ofek
Copy link
Contributor

@ofek ofek commented May 21, 2019 •
edited
Loading

Motivation

yaml/pyyaml#301

@ofek ofek added kind/packaging [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. team/integrations component/config labels May 21, 2019
@ofek ofek added this to the 6.12.0 milestone May 21, 2019
@ofek ofek requested a review from a team as a code owner May 21, 2019 22:46
@ofek ofek mentioned this pull request May 22, 2019
Merged
@ofek ofek force-pushed the ofek/pyyaml-patch branch from 789f342 to 4346fbe Compare May 22, 2019 05:20
@ofek ofek force-pushed the ofek/pyyaml-patch branch from 5c7d0c9 to c6e4644 Compare May 22, 2019 07:09
masci
masci approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

olivielpeau
olivielpeau approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and all pkg builds are confirmed to be working 💚

@masci masci merged commit bec3c0c into master May 22, 2019
@masci masci deleted the ofek/pyyaml-patch branch May 22, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivielpeau olivielpeau olivielpeau approved these changes

@masci masci masci approved these changes

Assignees
No one assigned
Labels
component/config [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. kind/packaging team/integrations
Projects
None yet
Milestone
6.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @masci @olivielpeau