Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle testing operations with optional arguments #1423

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Handle testing operations with optional arguments #1423

merged 2 commits into from
Apr 1, 2022

Conversation

Stoovles
Copy link
Contributor

@Stoovles Stoovles commented Apr 1, 2022 •
edited
Loading

What does this PR do?

  • Add handling for optional params to avoid index out of range errors

Additional Notes

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.

  • This PR does not rely on API client schema changes.

    • The CI should be fully passing.

  • Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@Stoovles Stoovles added the changelog/no-changelog Changes don't appear in changelog label Apr 1, 2022
@Stoovles Stoovles requested a review from a team as a code owner April 1, 2022 00:16
@Stoovles Stoovles changed the title Add handling for optional params to avoid index out of range errors Handle testing operations with optional arguments Apr 1, 2022
@Stoovles Stoovles merged commit dc7f512 into master Apr 1, 2022
@Stoovles Stoovles deleted the optional_param_handling branch April 1, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NouemanKHAL NouemanKHAL NouemanKHAL approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog Changes don't appear in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stoovles @NouemanKHAL @jirikuncar