Add step to assert a field is not present #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarimo
approved these changes
Mar 11, 2024
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 0s) Use |
|
🚨 MergeQueue Gitlab pipeline didn't start on its own and we were unable to create it... Please retry. If you need support, contact us on Slack #ci-interfaces with those details! |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
* Add step to assert a field is not present * Fix method naming --------- Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com> 6554c54
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Apr 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/DataDog/agent-payload/v5](https://github.com/DataDog/agent-payload) | `v5.0.104` -> `v5.0.111` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-api-client-go/v2](https://github.com/DataDog/datadog-api-client-go) | `v2.22.0` -> `v2.24.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>DataDog/agent-payload (github.com/DataDog/agent-payload/v5)</summary> ### [`v5.0.111`](https://github.com/DataDog/agent-payload/releases/tag/v5.0.111): [CWS] Udpate the CWS proto for the security profiles sliding window purpose [Compare Source](https://github.com/DataDog/agent-payload/compare/v5.0.110...v5.0.111) This new proto version update the security profile proto, deprecating some fields and adding the version contexts PR needed for the [related work on security profile sliding window](https://github.com/DataDog/datadog-agent/pull/20506) #### What's Changed - \[CWS] Udpate the CWS proto for the security profiles sliding window purpose by [@​spikat](https://github.com/spikat) in [DataDog/agent-payload#292 #### New Contributors - [@​spikat](https://github.com/spikat) made their first contribution in [DataDog/agent-payload#292 **Full Changelog**: DataDog/agent-payload@v5.0.110...v5.0.111 ### [`v5.0.110`](https://github.com/DataDog/agent-payload/releases/tag/v5.0.110) [Compare Source](https://github.com/DataDog/agent-payload/compare/v5.0.109...v5.0.110) #### What's Changed - add TypeCollectorECSTask by [@​kangyili](https://github.com/kangyili) in [DataDog/agent-payload#296 **Full Changelog**: DataDog/agent-payload@v5.0.109...v5.0.110 ### [`v5.0.109`](https://github.com/DataDog/agent-payload/releases/tag/v5.0.109) [Compare Source](https://github.com/DataDog/agent-payload/compare/v5.0.108...v5.0.109) #### What's Changed - cronjob status: add lastSuccessfultime by [@​aureleoules](https://github.com/aureleoules) in [DataDog/agent-payload#295 **Full Changelog**: DataDog/agent-payload@v5.0.108...v5.0.109 ### [`v5.0.108`](https://github.com/DataDog/agent-payload/releases/tag/v5.0.108) [Compare Source](https://github.com/DataDog/agent-payload/compare/v5.0.107...v5.0.108) #### What's Changed - Add repo digest field to container payload by [@​badovm](https://github.com/badovm) in [DataDog/agent-payload#293 - ecs task lifecycle event by [@​kangyili](https://github.com/kangyili) in [DataDog/agent-payload#282 - add ecs task payload by [@​kangyili](https://github.com/kangyili) in [DataDog/agent-payload#281 #### New Contributors - [@​badovm](https://github.com/badovm) made their first contribution in [DataDog/agent-payload#293 **Full Changelog**: DataDog/agent-payload@v5.0.107...v5.0.108 ### [`v5.0.107`](https://github.com/DataDog/agent-payload/releases/tag/v5.0.107) [Compare Source](https://github.com/DataDog/agent-payload/compare/v5.0.106...v5.0.107) **Full Changelog**: DataDog/agent-payload@v5.0.106...v5.0.107 #### What's Changed - Add repo digest field to container payload by [@​badovm](https://github.com/badovm) in [DataDog/agent-payload#293 #### New Contributors - [@​badovm](https://github.com/badovm) made their first contribution in [DataDog/agent-payload#293 **Full Changelog**: DataDog/agent-payload@v5.0.106...v5.0.107 ### [`v5.0.106`](https://github.com/DataDog/agent-payload/releases/tag/v5.0.106) [Compare Source](https://github.com/DataDog/agent-payload/compare/v5.0.105...v5.0.106) #### What's Changed - Add TRACE HTTP method to process payload by [@​vitkyrka](https://github.com/vitkyrka) in [DataDog/agent-payload#291 #### New Contributors - [@​vitkyrka](https://github.com/vitkyrka) made their first contribution in [DataDog/agent-payload#291 **Full Changelog**: DataDog/agent-payload@v5.0.105...v5.0.106 ### [`v5.0.105`](https://github.com/DataDog/agent-payload/releases/tag/v5.0.105) [Compare Source](https://github.com/DataDog/agent-payload/compare/v5.0.104...v5.0.105) #### What's Changed - Add NetworkPolicy protobuf definition by [@​aureleoules](https://github.com/aureleoules) in [DataDog/agent-payload#290 #### New Contributors - [@​aureleoules](https://github.com/aureleoules) made their first contribution in [DataDog/agent-payload#290 **Full Changelog**: DataDog/agent-payload@v5.0.104...v5.0.105 </details> <details> <summary>DataDog/datadog-api-client-go (github.com/DataDog/datadog-api-client-go/v2)</summary> ### [`v2.24.0`](https://github.com/DataDog/datadog-api-client-go/releases/tag/v2.24.0) [Compare Source](https://github.com/DataDog/datadog-api-client-go/compare/v2.23.0...v2.24.0) <!-- Release notes generated using configuration in .github/release.yml at v2.24.0 --> ##### What's Changed ##### Fixed - Disable additionalProperties for Downtime Schedule UpdateRequest oneOfs by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2390 - Fix ListServiceDefinitions pagination information by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2416 ##### Added - Adds support for `ListMetricAssets` endpoint by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2404 - Add support for new CRUD agent rules endpoints by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2410 - Add documentation for workflow usage attribution by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2418 - Add Custom Destinations Public API by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2422 ##### Deprecated - Deprecate the pattern property for SDS Standard Pattern Attributes by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2411 - Deprecate Incident Services endpoints by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2424 ##### New Contributors - [@​antonio-ramadas-dd](https://github.com/antonio-ramadas-dd) made their first contribution in [DataDog/datadog-api-client-go#2421 **Full Changelog**: DataDog/datadog-api-client-go@v2.23.0...v2.24.0 ### [`v2.23.0`](https://github.com/DataDog/datadog-api-client-go/releases/tag/v2.23.0) [Compare Source](https://github.com/DataDog/datadog-api-client-go/compare/v2.22.0...v2.23.0) <!-- Release notes generated using configuration in .github/release.yml at v2.23.0 --> #### What's Changed ##### Fixed - Move under common tag Case Management by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2385 - Include user data with team membership resource by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2380 ##### Added - Case Management Public API documentation by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2364 - Make grpc steps available for synthetics api multisteps tests by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2384 - Add cloud run filter to GCP v1 and v2 spec by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2361 - add ASM serverless to usage metering API docs by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2393 - Add new products to usage API docs by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2396 ##### Changed - Update spec for DORA Metrics Incident endpoint by [@​api-clients-generation-pipeline](https://github.com/api-clients-generation-pipeline) in [DataDog/datadog-api-client-go#2381 **Full Changelog**: DataDog/datadog-api-client-go@v2.22.0...v2.23.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new step to assert on Cucumber that a field is missing. This allows us to be more comprehensive when writing tests.
Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.