chore: fix some code style #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
commented
Aug 15, 2024
| @@ -34,7 +34,6 @@ export const DefaultDatadogProps = { | |||
| enableMergeXrayTraces: false, | |||
| injectLogContext: true, | |||
| enableDatadogLogs: true, | |||
| architecture: "X86_64", | |||
There was a problem hiding this comment.
Removing unused const
| log.debug("Granting read access to the provided Secret ARN for all your lambda functions."); | ||
| grantReadLambdasFromSecretArn(construct, this.props.apiKeySecretArn, extractedLambdaFunctions); | ||
| } | ||
| if (extractedLambdaFunctions.length === 0) { |
There was a problem hiding this comment.
this.propscan't beundefined, so removing this check.- flip the if condition and move the large chunk of code outside the if block
| const isARM = | ||
| lam.architecture?.dockerPlatform !== undefined && | ||
| lam.architecture.dockerPlatform === Architecture.ARM_64.dockerPlatform; | ||
| const isARM = lam.architecture?.dockerPlatform === Architecture.ARM_64.dockerPlatform; |
There was a problem hiding this comment.
Consolidating the two conditions
| lambdaLayerArn = getLambdaLayerArn(region, dotnetLayerVersion, runtime, isARM, accountId); | ||
| log.debug(`Using dd-trace-dotnet layer: ${lambdaLayerArn}`); | ||
| addLayer(lambdaLayerArn, false, scope, lam, runtime); | ||
| switch (lambdaRuntimeType) { |
There was a problem hiding this comment.
Changing to switch-case
lym953
commented
Aug 16, 2024
| @@ -86,6 +86,7 @@ eslintConfig.addOverride("extends", [ | |||
| ]); | |||
|
|
|||
| eslintConfig.addOverride("rules", { | |||
| "@typescript-eslint/switch-exhaustiveness-check": "error", | |||
There was a problem hiding this comment.
Lint rule for exhaustive switch-case
purple4reina
approved these changes
Aug 27, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make some fixes around code style
RuntimeTypesome day, the switch-case will become non-exhaustive and lint will remind us to handle the new value in the switch-caseto
to make code more readable.
See comments on code for more.
Motivation
Testing Guidelines
npx projen buildfinishes successfully.To test the link exhaustive check, I removed
from the switch-case block, then ran
npx projen build. I got an error as expected:Additional Notes
Types of Changes
Check all that apply