-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Decouple extensionLayerVersion
from addLayers
#303
Conversation
extensionLayerVersion
from addLayers
Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>
Heyo @neko-dd and/or @astuyve or @duncanista could I trouble you for a merge/release or more feedback if this approach is particularly troubling? Cheers 😄 |
Docs doesn't merge in this repo - I'll check in tomorrow to see if someone else has merged this, and if not I'll try to escalate for you. Thanks! |
Confirmed with @purple4reina and @TophrC-dd that this PR is good. Merging. |
Merged and released. |
Appreciate it, thanks! |
What does this PR do?
Resolves #201
addLayers
property.Motivation
I would like to instrument my lambda with the node libraries without layers but the extension library is required to be added as a layer.
At the moment I use an ugly workaround to allow for this behaviour.
https://github.com/seek-oss/skuba/blob/ca287dfa624f1739fbb349bc22dfde3be9b09919/template/lambda-sqs-worker-cdk/infra/appStack.ts#L130-L139
Testing Guidelines
Additional Notes
Types of Changes
Arguably this is a minor breaking change if the user was relying on
addLayers
to prevent layers from being added whilst specifying the extensionLayerVersion but I would hope that this is uncommon.Check all that apply