Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Decouple extensionLayerVersion from addLayers #303

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

samchungy
Copy link
Contributor

@samchungy samchungy commented Sep 28, 2024

What does this PR do?

Resolves #201

  • Allows the extension layer to be added regardless of the addLayers property.

Motivation

I would like to instrument my lambda with the node libraries without layers but the extension library is required to be added as a layer.

At the moment I use an ugly workaround to allow for this behaviour.

https://github.com/seek-oss/skuba/blob/ca287dfa624f1739fbb349bc22dfde3be9b09919/template/lambda-sqs-worker-cdk/infra/appStack.ts#L130-L139

Testing Guidelines

  • Unit Tests

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Arguably this is a minor breaking change if the user was relying on addLayers to prevent layers from being added whilst specifying the extensionLayerVersion but I would hope that this is uncommon.

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@samchungy samchungy changed the title Decouple extensionLayerVersion from addLayers feat: Decouple extensionLayerVersion from addLayers Sep 28, 2024
@samchungy samchungy marked this pull request as ready for review September 28, 2024 14:53
@samchungy samchungy requested review from a team as code owners September 28, 2024 14:53
README.md Outdated Show resolved Hide resolved
samchungy and others added 2 commits October 1, 2024 09:40
Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>
@samchungy
Copy link
Contributor Author

Heyo @neko-dd and/or @astuyve or @duncanista could I trouble you for a merge/release or more feedback if this approach is particularly troubling? Cheers 😄

@neko-dd
Copy link
Contributor

neko-dd commented Oct 10, 2024

Docs doesn't merge in this repo - I'll check in tomorrow to see if someone else has merged this, and if not I'll try to escalate for you. Thanks!

@lym953
Copy link
Contributor

lym953 commented Oct 17, 2024

Confirmed with @purple4reina and @TophrC-dd that this PR is good. Merging.

@lym953 lym953 merged commit db1738f into DataDog:main Oct 17, 2024
5 checks passed
@lym953
Copy link
Contributor

lym953 commented Oct 17, 2024

Merged and released.

@samchungy
Copy link
Contributor Author

Appreciate it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension layer should always be added regardless of addLayers prop
3 participants